Skip to content

Revert "Scope macOS signing secrets to release environment"#22513

Merged
shijie-oai merged 1 commit into
mainfrom
revert-22443-shijie/macos-signing-environment
May 13, 2026
Merged

Revert "Scope macOS signing secrets to release environment"#22513
shijie-oai merged 1 commit into
mainfrom
revert-22443-shijie/macos-signing-environment

Conversation

@shijie-oai
Copy link
Copy Markdown
Collaborator

Reverts #22443

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 643870a53e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +72 to +77
- runner: macos-15-xlarge
target: aarch64-apple-darwin
bundle: primary
artifact_name: aarch64-apple-darwin
binaries: "codex codex-responses-api-proxy"
build_dmg: "true"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore the macOS signing environment

For these macOS matrix entries, the job now runs under build, which no longer declares environment: macos-signing like the deleted build-macos job did. If the Apple certificate/notarization credentials are still scoped to that environment, GitHub will not expose them to this job, and .github/actions/macos-code-sign will fail immediately on its required empty inputs during every macOS release leg.

Useful? React with 👍 / 👎.

@shijie-oai shijie-oai merged commit 157fffc into main May 13, 2026
27 checks passed
@shijie-oai shijie-oai deleted the revert-22443-shijie/macos-signing-environment branch May 13, 2026 17:41
@github-actions github-actions Bot locked and limited conversation to collaborators May 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants