Deprecate TurnContext cwd and resolve_path#22519
Merged
Merged
Conversation
…ate-turn-cwd # Conflicts: # codex-rs/core/src/session/tests.rs # codex-rs/core/src/session/tests/guardian_tests.rs # codex-rs/core/src/tools/handlers/shell/container_exec.rs # codex-rs/core/src/tools/handlers/shell/shell_handler.rs
starr-openai
approved these changes
May 13, 2026
pakrym-oai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
TurnContext::cwdandTurnContext::resolve_pathare being phased out in favor of using the selected turn environment cwd directly. Deprecating both APIs makes any new direct dependency visible while preserving the existing migration path for current callers.What Changed
TurnContext::cwdandTurnContext::resolve_pathas deprecated with guidance to use the selected turn environment cwd instead.#[allow(deprecated)]suppressions at each existing direct usage site, including tests, rather than adding crate-wide suppression.Verification
just fmtcargo check -p codex-corecargo check -p codex-core --testsgit diff --check