POC: Add Code Mode files tool golden tests#22525
Draft
lt-oai wants to merge 1 commit into
Draft
Conversation
9d7cb3e to
97b8a13
Compare
4d0a432 to
5477a17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Reviewers need to see that this is wired through the regular Codex Code Mode harness, not only the Responses API/Python path.
What
filesnamespace is gated and handler-backed.files_copy,files_export_for_tool, andfiles_materialize.codex-toolscoverage showing namespaced tools flatten into the Code Mode runtime shape.Testing
cargo test -p codex-tools namespace_tools_are_flattened_for_code_mode_runtimecargo test -p codex-core files_namespace_is_gated_by_experimental_supported_toolcargo test -p codex-core code_mode_exec_description_includes_gated_files_toolsjust fmt