Make proxy decider test DNS independent#22540
Open
starr-openai wants to merge 1 commit into
Open
Conversation
Co-authored-by: Codex <noreply@openai.com>
62c8bb9 to
4ea1f18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The managed network proxy decider test is meant to prove that the decider still runs after the session starts in full-access mode and then returns to workspace-write restrictions. On Mike's devbox, the test's
example.comrequest can be classified by ambient DNS as local/private before the decider is consulted, so the same shard becomes flaky even though the proxy behavior is correct.What changed
8.8.8.8in the proxy request instead ofexample.comStack
Validation
dev:bazel test //codex-rs/core:core-unit-tests --test_filter=managed_network_proxy_decider_survives_full_access_start --runs_per_test=10 --test_output=errorspassed with 80 shard/run executions.