Skip to content

Prefer the model list fetched from the backend for SIWC users#22547

Merged
jeevnayak merged 2 commits into
mainfrom
jeev/update-model-cache-code
May 14, 2026
Merged

Prefer the model list fetched from the backend for SIWC users#22547
jeevnayak merged 2 commits into
mainfrom
jeev/update-model-cache-code

Conversation

@jeevnayak
Copy link
Copy Markdown
Contributor

@jeevnayak jeevnayak commented May 13, 2026

Summary

  • For SIWC users, update the model list merging logic to prefer the model list fetched from the backend over the bundled model list (this is needed for special cases where users have a more limited set of models they're allowed to use)
  • Add or update tests covering the revised cache behavior

Testing

  • Added/updated unit tests in codex-rs/models-manager/src/manager_tests.rs
  • Not run (not requested)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@jeevnayak jeevnayak changed the title update model cache handling in models manager Prefer the model list fetched from the backend for SIWC users May 13, 2026
Copy link
Copy Markdown
Collaborator

@sayan-oai sayan-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

please add an integration test for the e2e (subset/single model returned by /models using ChatGPT auth, model listing flow only has those models and no bundled models).

we prefer integration tests because codex changes unit tests too freely :)

@jeevnayak
Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@jeevnayak jeevnayak merged commit f13e21e into main May 14, 2026
31 of 32 checks passed
@jeevnayak jeevnayak deleted the jeev/update-model-cache-code branch May 14, 2026 17:45
@github-actions github-actions Bot locked and limited conversation to collaborators May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants