Prefer the model list fetched from the backend for SIWC users#22547
Merged
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
sayan-oai
approved these changes
May 13, 2026
Collaborator
sayan-oai
left a comment
There was a problem hiding this comment.
looks good!
please add an integration test for the e2e (subset/single model returned by /models using ChatGPT auth, model listing flow only has those models and no bundled models).
we prefer integration tests because codex changes unit tests too freely :)
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
sayan-oai
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
codex-rs/models-manager/src/manager_tests.rs