feat: make ToolExecutor an async trait#22560
Merged
Merged
Conversation
Collaborator
Author
|
@codex review |
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5c6c5b5b3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
codex_tools::ToolExecutorkeeps a tool spec attached to its runtime handler, but extension tools still carried a parallelExtensionToolFuture/ExtensionToolExecutorshape. That made extension-owned tools look different from host tools even though routing, registration, and execution need the same abstraction.This PR makes the shared executor contract directly async and lets extension tools implement it too, so host tools and extension tools can move through the same registration path.
What changed
ToolExecutor::handleto anasync fnusingasync-trait, and updated built-in tool handlers to implement the async trait directly.ExtensionToolFuturecontract with a markerExtensionToolExecutoroverToolExecutor<ToolCall, Output = JsonToolOutput>, re-exportingToolExecutorfromcodex-extension-api.Verification