tui: split composer attachment and popup state#22581
Merged
Merged
Conversation
This was referenced May 14, 2026
fcoury-oai
approved these changes
May 14, 2026
Contributor
fcoury-oai
left a comment
There was a problem hiding this comment.
Did a smoke test with some composer features and it worked as expected. Code looks good as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ChatComposercurrently owns text editing alongside attachment bookkeeping and popup lifecycle state, whileBottomPanestill triggers a couple of popup resyncs after composer methods that already do that work internally. That blurs the ownership boundary and makes the composer harder to simplify safely.This PR is part 1 of a two-part cleanup. It peels off the composer state that can move cleanly on its own, so the follow-up can tackle the heavier draft/editing boundary without mixing every concern into one diff.
What changed
AttachmentState.PopupState.BottomPanepopup synchronization after paste handling andinsert_str.Part 2
The follow-up PR will finish the cleanup around the remaining composer boundary: split out the draft/editing-oriented state and footer/status presentation concerns that still live in
ChatComposer, then revisit the leftoverBottomPanepass-throughs once those ownership lines are explicit. The goal is forChatComposerto coordinate a few focused collaborators instead of continuing to be the landing zone for every input-path concern.Verification
Did manual smoke tests.