[codex] treat PowerShell stop-parsing forms as unsupported#22643
Merged
Conversation
evawong-oai
approved these changes
May 14, 2026
Contributor
evawong-oai
left a comment
There was a problem hiding this comment.
Validated head 062c91b.
- The report payload now returns unsupported from the PowerShell parser on this head.
- The same payload returns ok on the base commit and is flattened into a command shape that keeps the post stop parsing text together, which confirms the regression path.
- Source checked that unsupported parser output does not produce parsed commands, so command safety treats this path as unsafe.
- Current CI is green for the required result and platform shards I checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The command-safety parser lowers PowerShell AST elements into argv-like words. Stop-parsing syntax preserves a native-command argument shape that this lowering does not model, so these forms should stay on the conservative unsupported path.
Validation
cargo fmt --manifest-path codex-rs/Cargo.toml --all --checkcargo test --manifest-path codex-rs/Cargo.toml -p codex-shell-command