Skip to content

[codex] treat PowerShell stop-parsing forms as unsupported#22643

Merged
bookholt-oai merged 1 commit into
mainfrom
codex/powershell-stop-parsing-unsupported
May 14, 2026
Merged

[codex] treat PowerShell stop-parsing forms as unsupported#22643
bookholt-oai merged 1 commit into
mainfrom
codex/powershell-stop-parsing-unsupported

Conversation

@bookholt-oai
Copy link
Copy Markdown
Contributor

Summary

  • Treat PowerShell stop-parsing token forms as unsupported in the AST-backed command flattener.
  • Add focused regressions at the parser layer and Windows command-safety layer.

Why

The command-safety parser lowers PowerShell AST elements into argv-like words. Stop-parsing syntax preserves a native-command argument shape that this lowering does not model, so these forms should stay on the conservative unsupported path.

Validation

  • cargo fmt --manifest-path codex-rs/Cargo.toml --all --check
  • cargo test --manifest-path codex-rs/Cargo.toml -p codex-shell-command

@bookholt-oai bookholt-oai marked this pull request as ready for review May 14, 2026 13:14
Copy link
Copy Markdown
Contributor

@evawong-oai evawong-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated head 062c91b.

  1. The report payload now returns unsupported from the PowerShell parser on this head.
  2. The same payload returns ok on the base commit and is flattened into a command shape that keeps the post stop parsing text together, which confirms the regression path.
  3. Source checked that unsupported parser output does not produce parsed commands, so command safety treats this path as unsafe.
  4. Current CI is green for the required result and platform shards I checked.

@bookholt-oai bookholt-oai marked this pull request as draft May 14, 2026 13:19
@bookholt-oai bookholt-oai marked this pull request as ready for review May 14, 2026 13:28
@bookholt-oai bookholt-oai merged commit 9ea3813 into main May 14, 2026
31 checks passed
@bookholt-oai bookholt-oai deleted the codex/powershell-stop-parsing-unsupported branch May 14, 2026 13:28
@github-actions github-actions Bot locked and limited conversation to collaborators May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants