Skip to content

Trim TUI legacy core helper usage#22695

Merged
etraut-openai merged 1 commit into
mainfrom
etraut/remove-tui-legacy-core-helpers
May 14, 2026
Merged

Trim TUI legacy core helper usage#22695
etraut-openai merged 1 commit into
mainfrom
etraut/remove-tui-legacy-core-helpers

Conversation

@etraut-openai
Copy link
Copy Markdown
Collaborator

@etraut-openai etraut-openai commented May 14, 2026

Why

The TUI still had a few low-risk dependencies flowing through the transitional legacy_core namespace after the app-server migration. These helpers either already have clearer non-core owners or are presentation logic that does not belong in codex-core, so moving them out reduces the compatibility surface without changing product behavior.

What changed

This is a low-risk change, almost completely mechanical in nature.

  • Route TUI Codex-home lookup through codex-utils-home-dir, use Config::log_dir directly, and call codex-sandboxing::system_bwrap_warning without going through legacy_core.
  • Move shared codex resume hint formatting from codex-core into codex-utils-cli.
  • Update CLI and TUI call sites to use the shared CLI utility, and keep the resume-command behavior covered by tests in its new home.

Verification

  • cargo test -p codex-utils-cli
  • cargo test -p codex-utils-cli resume_command

@etraut-openai etraut-openai marked this pull request as ready for review May 14, 2026 21:38
@etraut-openai etraut-openai requested a review from a team as a code owner May 14, 2026 21:38
@etraut-openai etraut-openai changed the title [codex] trim TUI legacy core helper usage Trim TUI legacy core helper usage May 14, 2026
@etraut-openai etraut-openai merged commit 3dc278b into main May 14, 2026
46 of 47 checks passed
@etraut-openai etraut-openai deleted the etraut/remove-tui-legacy-core-helpers branch May 14, 2026 23:55
@github-actions github-actions Bot locked and limited conversation to collaborators May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants