Skip to content

[codex] Remove personality feature switch#22780

Open
dylan-hurd-oai wants to merge 2 commits into
mainfrom
dh--features--rm-personality
Open

[codex] Remove personality feature switch#22780
dylan-hurd-oai wants to merge 2 commits into
mainfrom
dh--features--rm-personality

Conversation

@dylan-hurd-oai
Copy link
Copy Markdown
Collaborator

@dylan-hurd-oai dylan-hurd-oai commented May 15, 2026

Summary

  • Mark Feature::Personality as a removed compatibility flag.
  • Remove runtime personality feature gating from config, model-manager, session, and TUI paths so personality behavior is always enabled. Users can opt out by setting personality to none
  • Delete obsolete disabled-personality test coverage and remove explicit personality flag enables from related fixtures.

Validation

  • Unit tests pass

@dylan-hurd-oai dylan-hurd-oai force-pushed the dh--features--rm-personality branch from bb87700 to 0b69a1c Compare May 15, 2026 05:58
Co-authored-by: Codex <noreply@openai.com>
@dylan-hurd-oai dylan-hurd-oai force-pushed the dh--features--rm-personality branch from 0b69a1c to acdb0c3 Compare May 16, 2026 07:22
@dylan-hurd-oai dylan-hurd-oai marked this pull request as ready for review May 16, 2026 08:52
@dylan-hurd-oai dylan-hurd-oai requested a review from a team as a code owner May 16, 2026 08:52
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This silently re-enables personality for anyone who had opted out with features.personality = false. Do we have any idea of what does it represent?
Should we add None as a personality choice?

id: Feature::Personality,
key: "personality",
stage: Stage::Stable,
stage: Stage::Removed,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants