[codex] Keep extension tools directly visible#22814
Draft
jif-oai wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep extension-owned tools directly model-visible even when their shared executor reports
ToolExposure::Deferred.Root cause
ExtensionToolAdapterstarted forwarding extension executor exposure, but extension adapters do not yet providesearch_info(). A deferred extension tool could therefore disappear from the model-visible tool list without becoming discoverable throughtool_search.Changes
ExtensionToolAdapterexposure back toDirectuntil extension-backed search metadata exists.Validation
just fmtcargo test -p codex-core deferred_extension_tools_remain_model_visiblecargo test -p codex-corehit an existing unrelated stack overflow inagent::control::tests::resume_agent_from_rollout_skips_descendants_when_parent_resume_fails.just fix -p codex-core