Skip to content

Remove zombie tools spec module#22820

Merged
jif-oai merged 1 commit into
mainfrom
codex/remove-tools-spec-module
May 15, 2026
Merged

Remove zombie tools spec module#22820
jif-oai merged 1 commit into
mainfrom
codex/remove-tools-spec-module

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented May 15, 2026

Summary

  • move tool_user_shell_type out of the old tools::spec module and call it from tools directly
  • attach the remaining spec planning model tests under spec_plan
  • delete core/src/tools/spec.rs

Tests

  • just fmt
  • cargo test -p codex-core tools::spec_plan

Note: a broader cargo test -p codex-core run on the earlier PR-head worktree still hit the pre-existing stack overflow in agent::control::tests::spawn_agent_fork_last_n_turns_keeps_only_recent_turns.

@jif-oai jif-oai marked this pull request as ready for review May 15, 2026 11:33
@jif-oai jif-oai requested a review from a team as a code owner May 15, 2026 11:33
@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented May 15, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai jif-oai merged commit c03cea4 into main May 15, 2026
45 of 47 checks passed
@jif-oai jif-oai deleted the codex/remove-tools-spec-module branch May 15, 2026 11:45
@github-actions github-actions Bot locked and limited conversation to collaborators May 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant