Add SubagentStop hook#22873
Open
abhinav-oai wants to merge 5 commits into
Open
Conversation
This was referenced May 15, 2026
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
SubagentStopruns when a thread-spawned subagent turn is about to finish. Thread-spawned subagents useSubagentStopinstead of the normal root-agentStophook.Configured handlers match on
agent_type. Hook input includes the normal stop fields plus:agent_id: the child thread id.agent_type: the resolved subagent type.agent_transcript_path: the child subagent transcript path.transcript_path: the parent thread transcript path.last_assistant_message: the final assistant message from the child turn, when available.stop_hook_active:truewhen the child is already continuing because an earlier stop-like hook blocked completion.SubagentStopshares the same completion-control semantics asStop, scoped to the child turn:decision: "block"with a non-emptyreasonrecords that reason as hook feedback and continues the child with that prompt.continue: falsestops the child turn. IfstopReasonis present, Codex surfaces it as the stop reason.Lifecycle Scope
Only thread-spawned subagents run
SubagentStop.Internal/system subagents such as Review, Compact, MemoryConsolidation, and Other do not run normal
Stophooks and do not runSubagentStop. This avoids exposing synthetic matcher labels for internal implementation paths.Stack
SubagentStart.SubagentStop.