[codex] Soften SQLite metadata sync failures#22899
Conversation
|
@codex review |
| } | ||
|
|
||
| fn sqlite_write_failure_should_block(patch: &ThreadMetadataPatch) -> bool { | ||
| // Before live metadata sync moved above the rollout writer, SQLite sync failures for |
There was a problem hiding this comment.
this sucks, but appears to be how the previous code worked? @owenlin0 does this seem correct to you (sqlite is required for app server metadata updates but not implicit metadata updates from core)?
There was a problem hiding this comment.
yeah, i guess so. this has been ~rare (and I haven't encountered it personally) but sounds right to me
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2015820064
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@wiltzius-openai if it's not too much trouble, can you link the PR that introduced the change in the PR body? |
done! |
3 participants
Summary
Root cause
The live thread metadata sync introduced after v0.131.0-alpha.8 moved append-derived metadata writes above the rollout writer. Those SQLite writes now propagated through the live thread flush path, so a corrupted optional state DB could surface as a transcript persistence warning even when JSONL writes still succeeded.
The hard failures were introduced in #22236