[3 of 4] tui: route feature and memory toggles through app server#22915
Open
etraut-openai wants to merge 18 commits into
Open
[3 of 4] tui: route feature and memory toggles through app server#22915etraut-openai wants to merge 18 commits into
etraut-openai wants to merge 18 commits into
Conversation
etraut-openai
force-pushed
the
etraut/tui-config-app-server-3-feature-toggles
branch
from
12fe1d5 to
15dc6d3
Compare
etraut-openai
force-pushed
the
etraut/tui-config-app-server-2-catalog-state
branch
from
ff17872 to
6a181fa
Compare
etraut-openai
force-pushed
the
etraut/tui-config-app-server-3-feature-toggles
branch
from
15dc6d3 to
d8375c8
Compare
etraut-openai
force-pushed
the
etraut/tui-config-app-server-3-feature-toggles
branch
from
d8375c8 to
d5f9063
Compare
…i-config-app-server-2-catalog-state # Conflicts: # codex-rs/tui/src/config_rpc.rs
…ut/tui-config-app-server-3-feature-toggles
…i-config-app-server-2-catalog-state # Conflicts: # codex-rs/tui/src/config_update.rs
…ut/tui-config-app-server-3-feature-toggles
…i-config-app-server-2-catalog-state
…ut/tui-config-app-server-3-feature-toggles
etraut-openai
added a commit
that referenced
this pull request
May 16, 2026
## Why The TUI can run against a remote app server, but several high-traffic settings still persisted by editing the local config file. That sends remote sessions' preference writes to the wrong machine and lets local disk state drift from the app-server-owned config. This is **[1 of 4]** in a stacked series that moves TUI-owned config mutations onto app-server APIs. ## What changed - Added a small TUI helper for typed app-server config writes. - Routed primary interactive preference writes through `config/batchWrite`. - Preserved existing profile scoping for settings that already support `profiles.<profile>.*` overrides. ## Config keys affected - `model` - `model_reasoning_effort` - `personality` - `service_tier` - `plan_mode_reasoning_effort` - `approvals_reviewer` - `notice.fast_default_opt_out` - Profile-scoped equivalents under `profiles.<profile>.*` ## Suggested manual validation - Connect the TUI to a remote app server, change `model` and `model_reasoning_effort`, reconnect, and confirm the remote config retained both values while the local `config.toml` did not change. - Change `personality`, `plan_mode_reasoning_effort`, and the explicit auto-review selection, then reconnect and confirm those choices persist through the app server. - Clear the service tier back to default and confirm `service_tier` is cleared while `notice.fast_default_opt_out = true` is persisted remotely. - Repeat one setting change with an active profile and confirm the write lands under `profiles.<profile>.*`. ## Stack 1. [#22913](#22913) `[1 of 4]` primary settings writes 2. [#22914](#22914) `[2 of 4]` app and skill enablement 3. [#22915](#22915) `[3 of 4]` feature and memory toggles 4. [#22916](#22916) `[4 of 4]` startup and onboarding bookkeeping
etraut-openai
force-pushed
the
etraut/tui-config-app-server-2-catalog-state
branch
from
df4e122 to
fd994c7
Compare
…ut/tui-config-app-server-3-feature-toggles # Conflicts: # codex-rs/app-server/src/config_manager_service.rs # codex-rs/app-server/tests/suite/v2/config_rpc.rs # codex-rs/tui/src/app.rs # codex-rs/tui/src/app/tests.rs # codex-rs/tui/src/config_update.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Experimental feature toggles and memory settings can update several related config values in one interaction. Keeping those writes local in a remote TUI session is especially dangerous because the UI can diverge from the app-server config while also leaving behind partially stale supporting keys.
This is [3 of 4] in a stacked series that moves TUI-owned config mutations onto app-server APIs.
What changed
Config keys affected
features.<feature_key>profiles.<profile>.features.<feature_key>approval_policysandbox_modeapprovals_reviewerwindows.sandboxfeatures.experimental_windows_sandboxfeatures.elevated_windows_sandboxfeatures.enable_experimental_windows_sandboxprofiles.<profile>.features.*memories.use_memoriesmemories.generate_memoriesprofiles.<profile>.memories.*Suggested manual validation
features.guardian_approval, reviewer state, approval policy, and sandbox mode coherently.false.windows.sandboxis updated while the legacy Windows feature keys are cleared.Stack
[1 of 4]primary settings writes[2 of 4]app and skill enablement[3 of 4]feature and memory toggles[4 of 4]startup and onboarding bookkeeping