goals: keep pause transitions explicit#23088
Merged
Merged
Conversation
etraut-openai
changed the title
Collaborator
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c6d28812b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jif-oai
approved these changes
May 18, 2026
|
|
||
| #[tokio::test] | ||
| async fn interrupt_accounts_active_goal_before_pausing() -> anyhow::Result<()> { | ||
| async fn interrupt_accounts_active_goal_without_pausing() -> anyhow::Result<()> { |
Collaborator
There was a problem hiding this comment.
Can we add a regression for the no-active-turn/unload path to?
# Conflicts: # codex-rs/core/src/goals.rs
# Conflicts: # codex-rs/core/src/goals.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This addresses several user-reported cases where active goals were paused even though the user had not explicitly asked for that transition:
The common problem was that core treated
TurnAbortReason::Interruptedas an implicit request to transition the persisted goal topaused. That made unrelated interrupt paths mutate goal state as a side effect, and in the multi-app-server case it allowed stale process teardown to pause a live goal owned by another running client.After this change, transitioning a goal to
pausedis always an explicit action performed by a client or another intentional goal-state mutation. It is never an implicit transition triggered by generic interrupt handling.Refs #22884.
What changed
GoalRuntimeEvent::TaskAborted.active.