Cap diagnostic log payloads#23180
Draft
etraut-openai wants to merge 2 commits into
Draft
Conversation
643ddff to
88b816c
Compare
Collaborator
Author
|
@codex review |
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 83e56dfc5e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
83e56df to
a73999a
Compare
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR caps risky diagnostic payloads before emitting
tracingevents, so every log sink receives a bounded value that's limited to 16K (keeping head and tail and truncating in the middle).What Changed
This adds
codex-utils-log, a small utility crate for rendering diagnostic payloads with a bounded head/tail preview. Oversized values includeoriginal_bytes,shown_bytes,omitted_bytes, and asha256digest so logs remain useful for correlation without storing the whole payload.It also caps no-newline MCP stderr buffering before those bytes are logged.
Affected Log Points
logging/messagedata/logger plus cancelled/progress/resource-update fields.Verification
cargo test -p codex-utils-logcargo test -p codex-rmcp-client stderr_logcargo check -p codex-core -p codex-tui -p codex-app-server -p codex-login -p codex-analyticsjust fix -p codex-utils-log -p codex-rmcp-client -p codex-core -p codex-tui -p codex-app-server -p codex-api -p codex-login -p codex-analyticsjust bazel-lock-check