Skip to content

feat(app-server): add optional thread_id to experimentalFeature/list#23335

Merged
owenlin0 merged 2 commits into
mainfrom
owen/cwd_for_features_list
May 18, 2026
Merged

feat(app-server): add optional thread_id to experimentalFeature/list#23335
owenlin0 merged 2 commits into
mainfrom
owen/cwd_for_features_list

Conversation

@owenlin0
Copy link
Copy Markdown
Collaborator

@owenlin0 owenlin0 commented May 18, 2026

Why

experimentalFeature/list reports effective feature enablement, but currently does not resolve it against a working directory where project-local config.toml files can exist and toggle on/off features when merged into the effective config after resolving the various config layers. That means we effectively (and incorrectly) ignore features set in project-local config.

To address that, this PR exposes an optional thread_id param which allows us to load the thread's `cwd.

Testing

  • cargo test -p codex-app-server-protocol
  • cargo test -p codex-app-server experimental_feature_list

@owenlin0 owenlin0 changed the title feat(app-server): add optional to experimentalFeature/list feat(app-server): add optional cwd to experimentalFeature/list May 18, 2026
@owenlin0 owenlin0 marked this pull request as ready for review May 18, 2026 17:28
@owenlin0 owenlin0 requested a review from sayan-oai May 18, 2026 17:28
@owenlin0 owenlin0 changed the title feat(app-server): add optional cwd to experimentalFeature/list feat(app-server): add optional thread_id to experimentalFeature/list May 18, 2026
@owenlin0 owenlin0 requested a review from pakrym-oai May 18, 2026 18:28
@owenlin0 owenlin0 merged commit 139365a into main May 18, 2026
31 checks passed
@owenlin0 owenlin0 deleted the owen/cwd_for_features_list branch May 18, 2026 19:12
@github-actions github-actions Bot locked and limited conversation to collaborators May 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants