Skip to content

Include plugin id in plugin MCP tool metadata#23353

Merged
mzeng-openai merged 1 commit into
mainfrom
dev/mzeng/mcp_plugin_id_call_meta
May 18, 2026
Merged

Include plugin id in plugin MCP tool metadata#23353
mzeng-openai merged 1 commit into
mainfrom
dev/mzeng/mcp_plugin_id_call_meta

Conversation

@mzeng-openai
Copy link
Copy Markdown
Collaborator

@mzeng-openai mzeng-openai commented May 18, 2026

Adding the id of the plugin that contains the MCP (if any) so we can apply filters at plugin level.

Summary

  • carry the plugin owner into MCP runtime provenance
  • attach plugin_id to outbound plugin-backed MCP tool-call _meta
  • avoid misattributing user-configured MCP servers that shadow plugin server names

Testing

  • just fmt
  • just fix -p codex-mcp
  • just fix -p codex-core
  • cargo test -p codex-mcp
  • cargo test -p codex-core plugin_mcp_tool_call_request_meta_includes_plugin_id
  • cargo test -p codex-core to_mcp_config_omits_plugin_id_when_user_server_shadows_plugin_mcp
  • cargo test -p codex-core rebuild_preserving_session_layers_refreshes_plugin_derived_mcp_config
  • git diff --check

Notes

  • Attempted cargo test -p codex-core; it aborted in agent::control::tests::resume_agent_from_rollout_skips_descendants_when_parent_resume_fails with a stack overflow before the full suite completed.

@mzeng-openai mzeng-openai marked this pull request as ready for review May 18, 2026 20:32
@mzeng-openai mzeng-openai requested a review from a team as a code owner May 18, 2026 20:32
@mzeng-openai mzeng-openai merged commit a66e0e9 into main May 18, 2026
46 of 47 checks passed
@mzeng-openai mzeng-openai deleted the dev/mzeng/mcp_plugin_id_call_meta branch May 18, 2026 22:33
@github-actions github-actions Bot locked and limited conversation to collaborators May 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants