app-server: use profile ids in v2 permission params#23360
Merged
Conversation
b9ab23d to
c3af86a
Compare
viyatb-oai
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The v2 app-server permission profile fields are experimental, but the previous migration kept a legacy object payload for profile selection. That made clients aware of server-owned
activePermissionProfilemetadata such asextends, and it kept alegacy_additional_writable_rootspath even thoughruntimeWorkspaceRootsnow owns runtime workspace-root selection.This PR makes the client contract match the intended model: clients select a permission profile by id, and the server resolves and reports active profile provenance in response payloads.
Follow-up to #22611.
What Changed
thread/start,thread/resume,thread/fork, andturn/startpermission profile selection to plain profile id strings.command/exec.permissionProfileto a plain profile id string for the same client/server ownership split.PermissionProfileSelectionParamsand the legacy{ type: "profile", modifications: [...] }compatibility deserializer.codex execcall sites to send only ids, while keepingactivePermissionProfileas server response metadata.command/exec.permissionProfileshape.Verification
cargo test -p codex-app-server-protocolRUST_MIN_STACK=8388608 cargo test -p codex-app-servercargo test -p codex-execRUST_MIN_STACK=8388608 cargo test -p codex-tuiStack created with Sapling. Best reviewed with ReviewStack.