Skip to content

app-server: use profile ids in v2 permission params#23360

Merged
viyatb-oai merged 1 commit into
mainfrom
pr23360
May 19, 2026
Merged

app-server: use profile ids in v2 permission params#23360
viyatb-oai merged 1 commit into
mainfrom
pr23360

Conversation

@bolinfest
Copy link
Copy Markdown
Collaborator

@bolinfest bolinfest commented May 18, 2026

Why

The v2 app-server permission profile fields are experimental, but the previous migration kept a legacy object payload for profile selection. That made clients aware of server-owned activePermissionProfile metadata such as extends, and it kept a legacy_additional_writable_roots path even though runtimeWorkspaceRoots now owns runtime workspace-root selection.

This PR makes the client contract match the intended model: clients select a permission profile by id, and the server resolves and reports active profile provenance in response payloads.

Follow-up to #22611.

What Changed

  • Changed thread/start, thread/resume, thread/fork, and turn/start permission profile selection to plain profile id strings.
  • Changed command/exec.permissionProfile to a plain profile id string for the same client/server ownership split.
  • Removed PermissionProfileSelectionParams and the legacy { type: "profile", modifications: [...] } compatibility deserializer.
  • Updated app-server, TUI, and codex exec call sites to send only ids, while keeping activePermissionProfile as server response metadata.
  • Updated app-server docs and schema fixtures for the revised command/exec.permissionProfile shape.

Verification

  • cargo test -p codex-app-server-protocol
  • RUST_MIN_STACK=8388608 cargo test -p codex-app-server
  • cargo test -p codex-exec
  • RUST_MIN_STACK=8388608 cargo test -p codex-tui

Stack created with Sapling. Best reviewed with ReviewStack.

@viyatb-oai viyatb-oai merged commit 3fd79b7 into main May 19, 2026
46 checks passed
@viyatb-oai viyatb-oai deleted the pr23360 branch May 19, 2026 00:28
@github-actions github-actions Bot locked and limited conversation to collaborators May 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants