TUI: Default to unified mentions, deprecate gate, polish mentions rendering#23363
Draft
canvrno-oai wants to merge 11 commits into
Draft
TUI: Default to unified mentions, deprecate gate, polish mentions rendering#23363canvrno-oai wants to merge 11 commits into
canvrno-oai wants to merge 11 commits into
Conversation
Contributor
Author
|
@codex review |
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c8dd875041
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
898e68b to
0b55450
Compare
… remove legacy file popup, and improve plugin @mention rendering
… remove legacy file popup, and improve plugin @mention rendering
…or plugin mentions in composer
7c02a7a to
6ff2077
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes the unified
@mentionsthe default TUI behavior, removes the old split between file-only@search and tool mention behavior, folds the legacy file-search popup into the unified mentions flow, and keeps the oldmentions_v2config flag as a compatibility no-op so existing configs still load without warnings.It also adds a few small improvements to the mentions feature around mention rendering and history round-tripping for plugin/tool mentions in message edit scenarios. Plugin selections now insert
@mentions with better casing, and saved history preserves the visible sigil so recalled messages look the same as what the user typed.@mentionsand downgradesmentions_v2to a removed compatibility flag.@sigils when encoding/decoding mention history for tool/plugin paths.Steps to test
@in the TUI composer and verify filesystem/plugin/skill results are displayed in the unified mentions menu.@popup and confirm the inserted text is an@...mention with casing, then recall/edit the message and confirm it still renders as@....$skillmentions rather than@mentions.