fix(tui): warn on unsupported iTerm2 pet versions#23371
Merged
Conversation
32fcdf7 to
3ed10b9
Compare
3ed10b9 to
d436cd8
Compare
canvrno-oai
approved these changes
May 18, 2026
Contributor
canvrno-oai
left a comment
There was a problem hiding this comment.
Tested and reviewed. When running the /pets command on an older version of iTerm, the expected message was displayed:
⚠ Pets require iTerm2 3.6 or newer. Upgrade iTerm2 to use terminal pets.
When running in a newer iTerm version, /pets worked as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Older iTerm2 builds can be detected as supporting the image transport that terminal pets use, but in practice they fail to render the pet flow correctly. Instead of silently attempting image rendering, Codex should tell the user that their iTerm2 version is too old and that upgrading is the fix.
What Changed
3.6.0or newerHow to Test
/pets./pets.Targeted tests:
cargo test -p codex-terminal-detectioncargo test -p codex-tui pets::cargo test -p codex-tui slash_pets_on_unsupported_terminalcargo test -p codex-tui slash_pets_on_old_iterm2