Split plugin install discovery into list and request tools#23372
Merged
mzeng-openai merged 7 commits intoMay 19, 2026
Conversation
dylan-hurd-oai
approved these changes
May 19, 2026
dylan-hurd-oai
approved these changes
May 19, 2026
Collaborator
dylan-hurd-oai
left a comment
dylan-hurd-oai
left a comment
There was a problem hiding this comment.
LGTM, thank you!
Collaborator
There was a problem hiding this comment.
out of scope for this PR, but it would be excellent to migrate these tools to an extension!
…lugin-install-suggestion-flow # Conflicts: # codex-rs/core/src/tools/spec_plan.rs # codex-rs/core/src/tools/spec_plan_model_tests.rs # codex-rs/core/src/tools/spec_plan_tests.rs
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c8132352e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dylan-hurd-oai
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list_available_plugins_to_installas the inventory step for plugin and connector install suggestions.request_plugin_installso it only handles the actual elicitation, instead of carrying the full discoverable list in its prompt.SessionTelemetry, including tool type, user response action, and completion status.tool_suggestfeature gate unchanged.Testing
just fmtcargo test -p codex-toolscargo test -p codex-core request_plugin_installcargo test -p codex-core list_available_plugins_to_installcargo test -p codex-core install_suggestion_tools_can_be_registered_without_search_toolcargo test -p codex-otel manager_records_plugin_install_suggestion_metriccargo test -p codex-otel manager_records_plugin_install_elicitation_sent_metricjust fix -p codex-corejust fix -p codex-toolsjust fix -p codex-otelcargo check -p codex-core