Skip to content

Remove explicit connector tool undeferral#23390

Merged
sayan-oai merged 1 commit into
mainfrom
sayan/remove-explicit-connector-undeferral
May 19, 2026
Merged

Remove explicit connector tool undeferral#23390
sayan-oai merged 1 commit into
mainfrom
sayan/remove-explicit-connector-undeferral

Conversation

@sayan-oai
Copy link
Copy Markdown
Collaborator

@sayan-oai sayan-oai commented May 19, 2026

Summary

  • remove the explicit-connector carveout that kept mentioned app tools directly exposed instead of deferred
  • keep the surviving explicit-mention reconstruction only for analytics, preserving codex_app_mentioned and codex_app_used.invoke_type
  • trim the now-unused prompt/tool-exposure plumbing and refresh coverage around always-defer behavior

Verification

  • just fmt
  • cargo test -p codex-analytics
  • cargo test -p codex-core (one transient timeout in shell_snapshot::tests::macos_zsh_snapshot_includes_sections; isolated rerun passed)
  • cargo test -p codex-core --lib shell_snapshot::tests::macos_zsh_snapshot_includes_sections
  • cargo test -p codex-core --test all explicit_app_mentions_respect_always_defer
  • cargo test -p codex-core --lib mcp_tool_exposure::tests::always_defer_feature_defers_apps_too
  • just fix -p codex-analytics
  • just fix -p codex-core

@sayan-oai sayan-oai requested a review from a team as a code owner May 19, 2026 01:19
@sayan-oai sayan-oai force-pushed the sayan/remove-explicit-connector-undeferral branch from 5b35bd1 to ae1f6be Compare May 19, 2026 03:08
@sayan-oai
Copy link
Copy Markdown
Collaborator Author

@codex review this. we are explicitly removing the logic that would avoid deferral of connector tools on explicit mention.

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sayan-oai sayan-oai merged commit 1dd9bf9 into main May 19, 2026
31 checks passed
@sayan-oai sayan-oai deleted the sayan/remove-explicit-connector-undeferral branch May 19, 2026 04:33
@github-actions github-actions Bot locked and limited conversation to collaborators May 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants