Remove explicit connector tool undeferral#23390
Merged
Merged
Conversation
pakrym-oai
approved these changes
May 19, 2026
5b35bd1 to
ae1f6be
Compare
Collaborator
Author
|
@codex review this. we are explicitly removing the logic that would avoid deferral of connector tools on explicit mention. |
Contributor
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex_app_mentionedandcodex_app_used.invoke_typeVerification
just fmtcargo test -p codex-analyticscargo test -p codex-core(one transient timeout inshell_snapshot::tests::macos_zsh_snapshot_includes_sections; isolated rerun passed)cargo test -p codex-core --lib shell_snapshot::tests::macos_zsh_snapshot_includes_sectionscargo test -p codex-core --test all explicit_app_mentions_respect_always_defercargo test -p codex-core --lib mcp_tool_exposure::tests::always_defer_feature_defers_apps_toojust fix -p codex-analyticsjust fix -p codex-core