[codex] Make contextual user fragments dyn-renderable#23397
Merged
Conversation
aibrahim-oai
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ContextualUserFragmentneeds to be usable behinddynfor render-only paths, but associated constants made the trait non-object-safe.What changed
dyn ContextualUserFragmentcan render fragments.T::matches_text(text)registration pattern viatype_markers().render()on the main trait so implementations only provide role, markers, and body.Box<dyn ContextualUserFragment>.Verification
cargo test -p codex-core contextual_user_fragment_is_dyn_compatiblejust fix -p codex-core