Skip to content

Fix empty rollout path app-server handling#23400

Merged
wiltzius-openai merged 1 commit into
mainfrom
wiltzius/codex/empty-path-thread-resume
May 19, 2026
Merged

Fix empty rollout path app-server handling#23400
wiltzius-openai merged 1 commit into
mainfrom
wiltzius/codex/empty-path-thread-resume

Conversation

@wiltzius-openai
Copy link
Copy Markdown
Contributor

@wiltzius-openai wiltzius-openai commented May 19, 2026

Summary

  • Coerce path: "" to None at the v2 protocol params deserialization boundary for thread/resume and thread/fork.
  • Restore the pre-ThreadStore running-thread resume behavior: if threadId is already running, rejoin it by id and treat a non-empty path only as a consistency check; otherwise cold resume keeps history > path > threadId precedence.
  • Add protocol, resume, and fork regression coverage for empty path payloads; refresh app-server schema fixtures for the clarified params docs.

Tests

  • just fmt
  • just write-app-server-schema
  • cargo test -p codex-app-server-protocol thread_path_params_deserialize_empty_path_as_none
  • cargo test -p codex-app-server-protocol --test schema_fixtures
  • cargo test -p codex-app-server empty_path
  • RUST_MIN_STACK=8388608 cargo test -p codex-app-server --test all thread_resume_rejects_mismatched_path_for_running_thread_id
  • RUST_MIN_STACK=8388608 cargo test -p codex-app-server --test all thread_resume_uses_path_over_non_running_thread_id

@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/empty-path-thread-resume branch 3 times, most recently from d88da02 to 8023a14 Compare May 19, 2026 03:37
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/empty-path-thread-resume branch 3 times, most recently from 1fba352 to 7f460c3 Compare May 19, 2026 17:34
@wiltzius-openai wiltzius-openai marked this pull request as ready for review May 19, 2026 18:11
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/empty-path-thread-resume branch from 7f460c3 to e4d5221 Compare May 19, 2026 18:19
Comment thread codex-rs/app-server-protocol/src/protocol/v2/thread.rs
Comment thread codex-rs/app-server-protocol/src/protocol/v2/thread.rs
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/empty-path-thread-resume branch from e4d5221 to 27b8a8c Compare May 19, 2026 19:31
@wiltzius-openai wiltzius-openai enabled auto-merge (squash) May 19, 2026 19:31
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/empty-path-thread-resume branch from 27b8a8c to 42320dd Compare May 19, 2026 20:56
@wiltzius-openai wiltzius-openai merged commit 954a9c8 into main May 19, 2026
31 checks passed
@wiltzius-openai wiltzius-openai deleted the wiltzius/codex/empty-path-thread-resume branch May 19, 2026 21:19
@github-actions github-actions Bot locked and limited conversation to collaborators May 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants