Fix empty rollout path app-server handling#23400
Merged
Merged
Conversation
d88da02 to
8023a14
Compare
1fba352 to
7f460c3
Compare
7f460c3 to
e4d5221
Compare
owenlin0
reviewed
May 19, 2026
owenlin0
approved these changes
May 19, 2026
e4d5221 to
27b8a8c
Compare
27b8a8c to
42320dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
path: ""toNoneat the v2 protocol params deserialization boundary forthread/resumeandthread/fork.threadIdis already running, rejoin it by id and treat a non-emptypathonly as a consistency check; otherwise cold resume keepshistory > path > threadIdprecedence.Tests
just fmtjust write-app-server-schemacargo test -p codex-app-server-protocol thread_path_params_deserialize_empty_path_as_nonecargo test -p codex-app-server-protocol --test schema_fixturescargo test -p codex-app-server empty_pathRUST_MIN_STACK=8388608 cargo test -p codex-app-server --test all thread_resume_rejects_mismatched_path_for_running_thread_idRUST_MIN_STACK=8388608 cargo test -p codex-app-server --test all thread_resume_uses_path_over_non_running_thread_id