fix(tui): preserve modified enter in plan questions#23536
Merged
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d35f2dd51
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
canvrno-oai
approved these changes
May 19, 2026
Contributor
canvrno-oai
left a comment
There was a problem hiding this comment.
Tested with /plan mode and triggering a free form (Tab/Add notes) input. Shift+Enter added a newline as expected without attempting to submit the partial entry. Compared against the current release, where the issue was easily duplicated following the same steps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Plan mode questionnaires reuse the shared composer for free-form answers, but the surrounding
request_user_inputoverlay still treated everyKeyCode::Enteras “advance to the next question.” That madeShift+Enterinsert a newline in the composer and then immediately advance the questionnaire anyway.Fixes #23448.
What Changed
RuntimeKeymapintoRequestUserInputOverlayso its embedded composer honors existing/keymapcomposer/editor remapsShift+Enternewline behavior and configured composer submit bindings inside the questionnaire UIHow to Test
request_user_inputquestionnaire with a free-form answer field.Shift+Enter.Enterwith the default keymap, and confirm the questionnaire advances as before.Targeted tests:
cargo test -p codex-tui bottom_pane::request_user_input::tests::freeform_ -- --nocaptureNotes
cargo test -p codex-tuistill reaches an unrelated existing stack overflow inapp::tests::discard_side_thread_removes_agent_navigation_entryon this checkout.just argument-comment-lintis locally blocked by Bazel analysis failing in externalcompiler-rtbefore the lint runs.