Skip to content

Remove unused ARC monitor path#23573

Merged
mzeng-openai merged 1 commit into
mainfrom
dev/mzeng/remove_unused_arc_monitor
May 19, 2026
Merged

Remove unused ARC monitor path#23573
mzeng-openai merged 1 commit into
mainfrom
dev/mzeng/remove_unused_arc_monitor

Conversation

@mzeng-openai
Copy link
Copy Markdown
Collaborator

@mzeng-openai mzeng-openai commented May 19, 2026

Summary

  • remove the unreachable ARC monitor path from MCP tool approval handling
  • delete the unused ARC monitor module/tests and trim the orphaned safety-monitor decision plumbing
  • keep always allow approvals on the existing auto-approval short-circuit without a dead monitor hop

Testing

  • cargo test -p codex-core mcp_tool_call
  • just fmt
  • just fix -p codex-core
  • git diff --check

Additional validation

  • Attempted cargo test -p codex-core; the library test target passed, then the integration target failed in this local environment.
  • The narrower MCP-focused rerun passed its unit coverage and only hit missing local test_stdio_server binaries in filtered integration cases.

@mzeng-openai mzeng-openai marked this pull request as ready for review May 19, 2026 23:19
@mzeng-openai mzeng-openai requested a review from a team as a code owner May 19, 2026 23:19
@mzeng-openai mzeng-openai merged commit b019a67 into main May 19, 2026
31 checks passed
@mzeng-openai mzeng-openai deleted the dev/mzeng/remove_unused_arc_monitor branch May 19, 2026 23:23
@github-actions github-actions Bot locked and limited conversation to collaborators May 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants