Skip to content

Keep network denial tests off remote exec path#23599

Open
starr-openai wants to merge 1 commit into
mainfrom
starr/fix-unified-exec
Open

Keep network denial tests off remote exec path#23599
starr-openai wants to merge 1 commit into
mainfrom
starr/fix-unified-exec

Conversation

@starr-openai
Copy link
Copy Markdown
Contributor

@starr-openai starr-openai commented May 20, 2026

Why

The latest merged main rust-ci-full run (26134557979) failed these Linux remote shard tests:

Both failures occurred before the tests reached the managed network-denial behavior they are meant to assert. The logs show exec_command routed through the remote exec-server path and failing with exec-server rejected request (-32603): No such file or directory (os error 2), after which the tests timed out waiting for ExecCommandEnd.

What Changed

  • Updated the shared network-denial test helper in codex-rs/core/tests/suite/unified_exec.rs so these two tests use the normal local test environment instead of opting into the unrelated remote exec-server path.

Verification

@starr-openai starr-openai marked this pull request as ready for review May 20, 2026 02:43
@starr-openai starr-openai requested a review from a team as a code owner May 20, 2026 02:43
@starr-openai starr-openai force-pushed the starr/fix-unified-exec branch from 286bf21 to 8ab9e53 Compare May 20, 2026 03:26
@starr-openai starr-openai force-pushed the starr/fix-unified-exec branch from 8ab9e53 to 062c768 Compare May 20, 2026 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant