Keep network denial tests off remote exec path#23599
Open
starr-openai wants to merge 1 commit into
Open
Conversation
286bf21 to
8ab9e53
Compare
8ab9e53 to
062c768
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The latest merged
mainrust-ci-fullrun (26134557979) failed these Linux remote shard tests:codex-core::all::suite::unified_exec::unified_exec_network_denial_emits_failed_background_end_eventin https://github.com/openai/codex/actions/runs/26134557979/job/76868559368codex-core::all::suite::unified_exec::unified_exec_short_lived_network_denial_emits_failed_end_eventin https://github.com/openai/codex/actions/runs/26134557979/job/76868559385Both failures occurred before the tests reached the managed network-denial behavior they are meant to assert. The logs show
exec_commandrouted through the remote exec-server path and failing withexec-server rejected request (-32603): No such file or directory (os error 2), after which the tests timed out waiting forExecCommandEnd.What Changed
codex-rs/core/tests/suite/unified_exec.rsso these two tests use the normal local test environment instead of opting into the unrelated remote exec-server path.Verification
rust-ci-fullrun26134557979, job links above, both failed with the same remote exec-server startup rejection before timing out.unified_exec_network_denial_emits_failed_background_end_eventin https://github.com/openai/codex/actions/runs/26137097959/job/76876104957, and https://github.com/openai/codex/actions/runs/26137094301 reproducedunified_exec_short_lived_network_denial_emits_failed_end_eventin https://github.com/openai/codex/actions/runs/26137094301/job/76876222111.