Preserve code mode output history budget#23622
Open
starr-openai wants to merge 1 commit into
Open
Conversation
e5a298d to
c69094d
Compare
c69094d to
6eab49c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The latest merged
mainrust-ci-fullrun26140492945failed these code-mode exec parity tests onmacos-aarch64after both nextest attempts:code_mode_exec_explicit_max_above_default_preserves_outputcode_mode_exec_explicit_max_above_default_truncates_larger_outputcode_mode_exec_explicit_max_above_truncation_policy_preserves_outputcode_mode_exec_without_max_preserves_output_beyond_defaultcode_mode_exec_without_max_preserves_output_beyond_truncation_policyCode mode was already shaping its own model-visible output using the
@execoutput budget. Conversation history then truncated that already-shaped tool output a second time with the turn-wide default policy, which erased larger explicit code-mode outputs before the follow-up request.What Changed
execandwaitreuse the same output budget they already use for code-mode result truncation when their outputs are recorded into history.Verification
26140492945/ jobs76885895905,76885895917, and76885895935.just fmtgit diff --checkdevfailed before sync/Bazel.codex-lsp-clivalidation for the changed Rust files; it is still building the workspace in the background as of PR creation.