add standalone websearch api client#23655
Conversation
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn search_posts_typed_request_and_parses_encrypted_output() { |
There was a problem hiding this comment.
might be a bit overkill of a test setup
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub settings: Option<SearchSettings>, | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub max_output_tokens: Option<u64>, |
There was a problem hiding this comment.
still finalizing schema but this is going to be supported to enable truncation of encrypted tool results serverside. this addresses the unbounded encrypted function call output concerns in #23500.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 798f30ab00
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review this |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
add standalone web search request types and a
codex-apiclient ahead of the extension-contributed search tool.this adds typed commands/settings and opaque encrypted output handling for the new standalone search flow. the endpoint types are close to finalized but may still shift slightly as that API settles.