Skip to content

add standalone websearch api client#23655

Merged
sayan-oai merged 1 commit into
mainfrom
dev/sayan/standalone-websearch-api-client
May 20, 2026
Merged

add standalone websearch api client#23655
sayan-oai merged 1 commit into
mainfrom
dev/sayan/standalone-websearch-api-client

Conversation

@sayan-oai
Copy link
Copy Markdown
Collaborator

add standalone web search request types and a codex-api client ahead of the extension-contributed search tool.

this adds typed commands/settings and opaque encrypted output handling for the new standalone search flow. the endpoint types are close to finalized but may still shift slightly as that API settles.

}

#[tokio::test]
async fn search_posts_typed_request_and_parses_encrypted_output() {
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be a bit overkill of a test setup

#[serde(skip_serializing_if = "Option::is_none")]
pub settings: Option<SearchSettings>,
#[serde(skip_serializing_if = "Option::is_none")]
pub max_output_tokens: Option<u64>,
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still finalizing schema but this is going to be supported to enable truncation of encrypted tool results serverside. this addresses the unbounded encrypted function call output concerns in #23500.

@sayan-oai sayan-oai marked this pull request as ready for review May 20, 2026 09:03
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 798f30ab00

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/codex-api/src/search.rs
@sayan-oai
Copy link
Copy Markdown
Collaborator Author

@codex review this

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sayan-oai sayan-oai merged commit ed6d73b into main May 20, 2026
31 checks passed
@sayan-oai sayan-oai deleted the dev/sayan/standalone-websearch-api-client branch May 20, 2026 18:38
@github-actions github-actions Bot locked and limited conversation to collaborators May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants