feat: account active goal progress in the goal extension#23696
Merged
Conversation
Collaborator
Author
|
@codex review |
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 29c43317d5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The goal extension can create and surface goals, but the live turn-accounting path still stopped short of persisting active-goal progress. That leaves token and wall-clock usage, plus
ThreadGoalUpdatedevents, out of sync with the extension boundary once work actually advances or a goal transitions out of active state.What changed
GoalAccountingStateto track the current turn, active goal, token deltas, and wall-clock progress snapshots against the persisted goal id.ThreadGoalUpdatedevents when persisted progress changes.create_goalandupdate_goalthrough the same accounting state so new goals start from the right baseline, final progress is flushed before status changes, andupdate_goalcan mark a goalblockedas well ascomplete.Testing
codex-rs/ext/goal/tests/goal_extension_backend.rsfor baseline reset, tool-finish accounting, budget-limited turns, and blocked-goal updates.codex-rs/core/src/session/tests.rsto assert that lifecycle inputs expose the expected session, thread, and turn store ids.