Skip to content

cli: add strict config to exec-server#23719

Merged
bolinfest merged 1 commit into
mainfrom
pr23719
May 20, 2026
Merged

cli: add strict config to exec-server#23719
bolinfest merged 1 commit into
mainfrom
pr23719

Conversation

@bolinfest
Copy link
Copy Markdown
Collaborator

@bolinfest bolinfest commented May 20, 2026

Why

PR #20559 added opt-in strict config parsing to the config-loading command surfaces, but codex exec-server was left out. That meant codex exec-server --strict-config was rejected even though the command can load config for remote registration, and local server startup had no way to fail fast on misspelled config keys.

What Changed

  • Added --strict-config to codex exec-server.
  • Allowed root-level inheritance from codex --strict-config exec-server.
  • Validated config before local exec-server startup when strict mode is requested.
  • Reused the loaded strict-config-aware config for remote exec-server registration auth.
  • Added CLI coverage showing codex exec-server --strict-config rejects unknown config fields.

Verification

  • cargo test -p codex-cli
  • New integration test: strict_config_rejects_unknown_config_fields_for_exec_server

Documentation

Any strict-config command list on developers.openai.com/codex should include codex exec-server with the other supported config-loading entry points.

@bolinfest
Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@bolinfest bolinfest merged commit d1e3d54 into main May 20, 2026
47 of 62 checks passed
@bolinfest bolinfest deleted the pr23719 branch May 20, 2026 20:12
@github-actions github-actions Bot locked and limited conversation to collaborators May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants