Skip to content

Fix thread settings clippy failure#23724

Merged
etraut-openai merged 3 commits into
mainfrom
etraut/fix-thread-settings-clippy
May 20, 2026
Merged

Fix thread settings clippy failure#23724
etraut-openai merged 3 commits into
mainfrom
etraut/fix-thread-settings-clippy

Conversation

@etraut-openai
Copy link
Copy Markdown
Collaborator

@etraut-openai etraut-openai commented May 20, 2026

Why

main picked up two small Rust build failures after nearby merges:

What changed

Removed the duplicate ThreadSettingsUpdated match pattern from tui/src/chatwidget/protocol.rs.

Updated the goal extension test tool_call helper to populate the new ToolCall fields, and reused that helper for the one direct literal that still had the old field list.

Verification

  • just fix -p codex-tui
  • cargo test -p codex-goal-extension

@etraut-openai etraut-openai marked this pull request as ready for review May 20, 2026 18:43
@etraut-openai etraut-openai changed the title [codex] Fix thread settings clippy failure [codex] Fix post-merge Rust build failures May 20, 2026
@etraut-openai etraut-openai changed the title [codex] Fix post-merge Rust build failures Fix thread settings clippy failure May 20, 2026
@etraut-openai etraut-openai merged commit 7c3cc1d into main May 20, 2026
30 checks passed
@etraut-openai etraut-openai deleted the etraut/fix-thread-settings-clippy branch May 20, 2026 18:58
@github-actions github-actions Bot locked and limited conversation to collaborators May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants