Fix thread settings clippy failure#23724
Merged
Merged
Conversation
fcoury-oai
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mainpicked up two small Rust build failures after nearby merges:ServerNotification::ThreadSettingsUpdated, but the same variant was still listed in the ignored-notification match arm. Full Clippy runs treat the resulting unreachable-pattern warning as an error.turn_idandtruncation_policytocodex_tools::ToolCall, while the goal extension backend test fixtures from the goal-extension work still used the old shape. That leftcodex-goal-extensiontests unable to compile once the branches met onmain.What changed
Removed the duplicate
ThreadSettingsUpdatedmatch pattern fromtui/src/chatwidget/protocol.rs.Updated the goal extension test
tool_callhelper to populate the newToolCallfields, and reused that helper for the one direct literal that still had the old field list.Verification
just fix -p codex-tuicargo test -p codex-goal-extension