Skip to content

[codex] List marketplaces considered by plugin discovery#23730

Merged
caseychow-oai merged 1 commit into
mainfrom
caseychow/codex/fix-marketplace-listing-roots
May 20, 2026
Merged

[codex] List marketplaces considered by plugin discovery#23730
caseychow-oai merged 1 commit into
mainfrom
caseychow/codex/fix-marketplace-listing-roots

Conversation

@caseychow-oai
Copy link
Copy Markdown
Contributor

@caseychow-oai caseychow-oai commented May 20, 2026

Summary

  • List codex plugin marketplace list from the manager-backed marketplace discovery path Codex uses before plugin-level filtering.
  • Include the implicit home marketplace at ~/.agents/plugins/marketplace.json, keep filtered marketplace roots visible, and print an aligned marketplace/root table.
  • Fail loudly when in-scope configured or implicit marketplaces are invalid, including malformed manifests, missing local sources, and invalid configured names.
  • Add CLI coverage for home discovery, filtered roots, load failures, invalid config, and table formatting.

Example

Illustrative output with sanitized marketplace roots:

$ codex plugin marketplace list
MARKETPLACE  ROOT
personal     /home/example
team         /workspace/plugins

Tests

  • just fmt
  • cargo test -p codex-core-plugins
  • just fix -p codex-core-plugins
  • Not run successfully: cargo test -p codex-cli --test plugin_cli (local webrtc-sys build fails on missing WebRTC headers)
  • Not run successfully: just fix -p codex-cli (same local webrtc-sys build failure)

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b195f7e099

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/cli/tests/plugin_cli.rs
Comment thread codex-rs/cli/src/marketplace_cmd.rs
@caseychow-oai caseychow-oai changed the title fix(cli): list marketplaces Codex is actually considering [codex] List marketplaces considered by plugin discovery May 20, 2026
@caseychow-oai caseychow-oai force-pushed the caseychow/codex/fix-marketplace-listing-roots branch from a0680c3 to 94d67f4 Compare May 20, 2026 20:14
Co-authored-by: Codex <noreply@openai.com>
@caseychow-oai caseychow-oai force-pushed the caseychow/codex/fix-marketplace-listing-roots branch from 94d67f4 to 165b35e Compare May 20, 2026 22:44
@caseychow-oai
Copy link
Copy Markdown
Contributor Author

/merge

1 similar comment
@caseychow-oai
Copy link
Copy Markdown
Contributor Author

/merge

@caseychow-oai caseychow-oai merged commit 60b45d9 into main May 20, 2026
45 of 47 checks passed
@caseychow-oai caseychow-oai deleted the caseychow/codex/fix-marketplace-listing-roots branch May 20, 2026 23:17
@github-actions github-actions Bot locked and limited conversation to collaborators May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants