[codex] Add plugin id to MCP tool call items#23737
Merged
Merged
Conversation
…l_call_plugin_id_item # Conflicts: # codex-rs/core/src/mcp_tool_call.rs
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1b66bd07b2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
owenlin0
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add owning plugin id to MCP tool call items so we can better filter them at plugin level.
Summary
plugin_idto MCP tool-call items and legacy begin/end eventsThreadItem::McpToolCallTesting
just write-app-server-schemajust fmtjust fix -p codex-corecargo test -p codex-protocol -p codex-app-server-protocolcargo test -p codex-app-server-protocolcargo test -p codex-core mcp_tool_call_item_includes_plugin_id --libcargo check -p codex-tui --testscargo check -p codex-app-server --testsgit diff --checkNotes
just fix -p codex-corecompleted with two non-fataltoo_many_argumentswarnings on the touched MCP notification helpers.cargo test -p codex-corerun passed core unit tests, then hit shell/sandbox/snapshot failures in the integration target.in_process::tests::in_process_start_clamps_zero_channel_capacitystack overflow;cargo test -p codex-execalso hit the existing sandbox expectation mismatch inthread_lifecycle_params_include_legacy_sandbox_when_no_active_profile.