Conversation
shijie-oai
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Windows release job installed DotSlash successfully, but package archive creation still failed while writing
codex-package-*.tar.zst. The Python archiver usedshutil.which("zstd"), which does not reliably find the extensionless DotSlash manifest at.github/workflows/zstdfrom native Windows Python.That left release packaging dependent on a command named exactly
zstdbeing discoverable onPATH, even though the repository already carries a DotSlash wrapper for Windows runners.What changed
resolve_zstd_command()to prefer a realzstdbinary when present.dotslash .github/workflows/zstdwhenzstdis not onPATH.zstdnor the DotSlash fallback is available.zstd, DotSlash fallback, and missing-tool error paths.Verification
python3 -m unittest discover -s scripts/codex_package -p 'test_*.py'python3 -m py_compile scripts/codex_package/*.py