Skip to content

release: use DotSlash zstd for package archives#23752

Merged
bolinfest merged 1 commit into
mainfrom
pr23752
May 20, 2026
Merged

release: use DotSlash zstd for package archives#23752
bolinfest merged 1 commit into
mainfrom
pr23752

Conversation

@bolinfest
Copy link
Copy Markdown
Collaborator

@bolinfest bolinfest commented May 20, 2026

Why

The Windows release job installed DotSlash successfully, but package archive creation still failed while writing codex-package-*.tar.zst. The Python archiver used shutil.which("zstd"), which does not reliably find the extensionless DotSlash manifest at .github/workflows/zstd from native Windows Python.

That left release packaging dependent on a command named exactly zstd being discoverable on PATH, even though the repository already carries a DotSlash wrapper for Windows runners.

What changed

  • Add resolve_zstd_command() to prefer a real zstd binary when present.
  • Fall back to invoking dotslash .github/workflows/zstd when zstd is not on PATH.
  • Keep the error explicit when neither zstd nor the DotSlash fallback is available.
  • Add unit coverage for direct zstd, DotSlash fallback, and missing-tool error paths.

Verification

  • python3 -m unittest discover -s scripts/codex_package -p 'test_*.py'
  • python3 -m py_compile scripts/codex_package/*.py

@bolinfest bolinfest requested a review from shijie-oai May 20, 2026 21:21
@bolinfest bolinfest merged commit f48be01 into main May 20, 2026
31 checks passed
@bolinfest bolinfest deleted the pr23752 branch May 20, 2026 21:28
@github-actions github-actions Bot locked and limited conversation to collaborators May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants