Remove Windows sandbox resource stamping#23764
Merged
Merged
Conversation
zm-oai
approved these changes
May 20, 2026
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4dfcea7e7c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
4dfcea7 to
5d23fde
Compare
zm-oai
approved these changes
May 20, 2026
fdcf226 to
5d2741e
Compare
5d2741e to
08861fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
codex-windows-sandboxcrate was embedding Windows resource metadata through a package-levelbuild.rs. Because that package also exposes thecodex_windows_sandboxlibrary, downstream binaries that link the library could inheritFileDescription/ProductNamevalues ofcodex-windows-sandbox.That made ordinary Codex binaries, including the long-lived
codex.exeapp-server sidecar, appear ascodex-windows-sandboxin Windows UI surfaces such as Task Manager / file properties.We do not rely on this metadata enough to justify a larger bin-only resource split, so this removes the resource stamping entirely.
What changed
windows-sandbox-rsbuild script that invokedwinres.winresbuild dependency and correspondingCargo.lock/MODULE.bazel.lockentries.Verification
cargo build -p codex-windows-sandbox --binscargo build -p codex-cli --bin codexbazel mod deps --lockfile_mode=updatevia Bazelisk, with local remote-cache-disabling flags becausebazelis not installed on PATH herebazel mod deps --lockfile_mode=errorvia Bazelisk, with the same local flagscodex.exe,codex-command-runner.exe, andcodex-windows-sandbox-setup.exenow have blankFileDescription/ProductNamefields.cargo test -p codex-windows-sandboxstill fails on two legacy Windows sandbox tests withCreateRestrictedToken failed: 87and the follow-on poisoned test lock; 85 passed, 2 ignored.