Skip to content

Remove Windows sandbox resource stamping#23764

Merged
iceweasel-oai merged 1 commit into
mainfrom
codex/fix-sandbox-metadata-stamp
May 20, 2026
Merged

Remove Windows sandbox resource stamping#23764
iceweasel-oai merged 1 commit into
mainfrom
codex/fix-sandbox-metadata-stamp

Conversation

@iceweasel-oai
Copy link
Copy Markdown
Collaborator

@iceweasel-oai iceweasel-oai commented May 20, 2026

Why

The codex-windows-sandbox crate was embedding Windows resource metadata through a package-level build.rs. Because that package also exposes the codex_windows_sandbox library, downstream binaries that link the library could inherit FileDescription / ProductName values of codex-windows-sandbox.

That made ordinary Codex binaries, including the long-lived codex.exe app-server sidecar, appear as codex-windows-sandbox in Windows UI surfaces such as Task Manager / file properties.

We do not rely on this metadata enough to justify a larger bin-only resource split, so this removes the resource stamping entirely.

What changed

  • Removed the windows-sandbox-rs build script that invoked winres.
  • Removed the setup manifest that was only consumed by that build script.
  • Removed the winres build dependency and corresponding Cargo.lock / MODULE.bazel.lock entries.
  • Removed the now-unused Bazel build-script data.

Verification

  • cargo build -p codex-windows-sandbox --bins
  • cargo build -p codex-cli --bin codex
  • bazel mod deps --lockfile_mode=update via Bazelisk, with local remote-cache-disabling flags because bazel is not installed on PATH here
  • bazel mod deps --lockfile_mode=error via Bazelisk, with the same local flags
  • Verified rebuilt codex.exe, codex-command-runner.exe, and codex-windows-sandbox-setup.exe now have blank FileDescription / ProductName fields.
  • cargo test -p codex-windows-sandbox still fails on two legacy Windows sandbox tests with CreateRestrictedToken failed: 87 and the follow-on poisoned test lock; 85 passed, 2 ignored.

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4dfcea7e7c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/windows-sandbox-rs/Cargo.toml
@iceweasel-oai iceweasel-oai force-pushed the codex/fix-sandbox-metadata-stamp branch from 4dfcea7 to 5d23fde Compare May 20, 2026 22:10
@iceweasel-oai iceweasel-oai force-pushed the codex/fix-sandbox-metadata-stamp branch 2 times, most recently from fdcf226 to 5d2741e Compare May 20, 2026 22:47
@iceweasel-oai iceweasel-oai force-pushed the codex/fix-sandbox-metadata-stamp branch from 5d2741e to 08861fa Compare May 20, 2026 22:49
@iceweasel-oai iceweasel-oai merged commit 8253ae4 into main May 20, 2026
45 of 46 checks passed
@iceweasel-oai iceweasel-oai deleted the codex/fix-sandbox-metadata-stamp branch May 20, 2026 23:15
@github-actions github-actions Bot locked and limited conversation to collaborators May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants