standalone websearch extension#23823
Conversation
sayan-oai
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cdd92100c7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
usgenes39-dotcom
left a comment
usgenes39-dotcom
left a comment
There was a problem hiding this comment.
I found two blocking standalone-search semantics issues on the current head.
Current head fixes the earlier disabled-mode and settings-forwarding problems, but recent_input still sends unbounded user text/image content to alpha/search, and hosted web_search is hidden for OpenAI providers even in ThreadManager paths that do not install the standalone extension. That creates both unbounded search-context/cost risk and a product regression where web search disappears outside app-server. CI is not fully green on this head because the Bazel workflow was cancelled, and the PR is currently reported as not mergeable.
| use serde_json::Map; | ||
| use serde_json::Value; | ||
|
|
||
| pub(crate) fn commands_schema() -> Value { |
There was a problem hiding this comment.
might be interesting reusable method in the future
| use codex_protocol::models::ResponseItem; | ||
| use schemars::JsonSchema; | ||
| use serde::Deserialize; | ||
| use serde::Serialize; |
There was a problem hiding this comment.
Ideally we'd split APIs as well
sayan-oai
force-pushed
the
codex/standalone-web-search-extension
branch
from
4fe6460 to
4660ae3
Compare
jif-oai
left a comment
jif-oai
left a comment
There was a problem hiding this comment.
IMO looking way better. Happy to stamp once this is green and merged with main
| } | ||
|
|
||
| fn to_response_item(&self, call_id: &str, _payload: &ToolPayload) -> ResponseInputItem { | ||
| ResponseInputItem::FunctionCallOutput { |
There was a problem hiding this comment.
We will loose context pollution toggle but I'll take that as a follow-up
sayan-oai
force-pushed
the
codex/standalone-web-search-extension
branch
from
4660ae3 to
ac1fcb0
Compare
sayan-oai
force-pushed
the
codex/standalone-web-search-extension
branch
from
ac1fcb0 to
ad5959c
Compare
4 participants
Summary
Add the extension-backed standalone
web.runtool so Codex can call the standalone search endpoint through thecodex-apisearch client and return its encrypted output to Responses.standalone_web_searchweb_searchwhen standalone search is enabled for OpenAI providers so the two paths stay mutually exclusiveTest Plan
cargo test -p codex-web-search-extensioncargo test -p codex-apicargo test -p codex-core hosted_tools_follow_provider_auth_model_and_config_gates