Make tool executor specs mandatory#23870
Merged
Merged
Conversation
Collaborator
Author
|
@codex review |
Collaborator
Author
|
Windows failures are due to GH workers flake |
starr-openai
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ToolExecutoris the runtime contract that keeps a callable tool and its model-visible spec together. Leavingspec()optional lets a registered runtime silently omit that half of the contract, and it also overloads a missing spec as an exposure decision for tools that should stay dispatchable without being shown to the model.What
ToolExecutor::spec()required and update core, extension, and test tool executors to return a concreteToolSpec.ToolExposure::Hiddenfor dispatch-only tools. The legacyshell_commandruntime in unified-exec sessions now uses that explicit exposure instead of hiding itself by omitting a spec.McpHandleris constructed so invalid MCP specs are skipped before the handler is registered.Testing
shell_commandruntime and the affected tool executor test fixtures.