[codex] Enable Node env proxy for managed network proxy#23905
Merged
Conversation
Set NODE_USE_ENV_PROXY when Codex applies managed proxy environment overrides. Cover the Node proxy opt-in in network proxy env tests.
viyatb-oai
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NODE_USE_ENV_PROXY=1when Codex applies managed network proxy environment overridesWhy
Codex already sets HTTP proxy environment variables for child processes when the managed network proxy is active. Node's built-in network behavior needs the
NODE_USE_ENV_PROXYopt-in to honor those env vars, so Node-based skill scripts can otherwise skip the managed proxy path and fail under restricted network access.Validation
just fmtincodex-rscargo test -p codex-network-proxyincodex-rs