Skip to content

[codex] Enable Node env proxy for managed network proxy#23905

Merged
rreichel3-oai merged 1 commit into
mainfrom
rreichel3/node-use-env-proxy
May 22, 2026
Merged

[codex] Enable Node env proxy for managed network proxy#23905
rreichel3-oai merged 1 commit into
mainfrom
rreichel3/node-use-env-proxy

Conversation

@rreichel3-oai
Copy link
Copy Markdown
Contributor

Summary

  • set NODE_USE_ENV_PROXY=1 when Codex applies managed network proxy environment overrides
  • keep the Node opt-in in the proxy environment key set used by shell/runtime env handling
  • cover the new env var in the focused network proxy env test

Why

Codex already sets HTTP proxy environment variables for child processes when the managed network proxy is active. Node's built-in network behavior needs the NODE_USE_ENV_PROXY opt-in to honor those env vars, so Node-based skill scripts can otherwise skip the managed proxy path and fail under restricted network access.

Validation

  • just fmt in codex-rs
  • cargo test -p codex-network-proxy in codex-rs

Set NODE_USE_ENV_PROXY when Codex applies managed proxy environment overrides.

Cover the Node proxy opt-in in network proxy env tests.
@rreichel3-oai rreichel3-oai marked this pull request as ready for review May 22, 2026 05:27
@rreichel3-oai rreichel3-oai merged commit b14f11d into main May 22, 2026
31 checks passed
@rreichel3-oai rreichel3-oai deleted the rreichel3/node-use-env-proxy branch May 22, 2026 05:27
@github-actions github-actions Bot locked and limited conversation to collaborators May 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants