Skip to content

[codex] Make thread search case-insensitive#23921

Merged
fc-oai merged 1 commit into
mainfrom
fc/thread-search-case-insensitive
May 21, 2026
Merged

[codex] Make thread search case-insensitive#23921
fc-oai merged 1 commit into
mainfrom
fc/thread-search-case-insensitive

Conversation

@fc-oai
Copy link
Copy Markdown
Contributor

@fc-oai fc-oai commented May 21, 2026

Summary

  • make rollout content search prefilter rollout files case-insensitively
  • keep the no-ripgrep fallback scan and visible snippet matcher aligned with that behavior
  • cover a lowercase thread/search query matching mixed-case conversation content

Why

The rollout-backed thread/search path used exact string matching in both its rg prefilter and semantic snippet generation. A content result could be missed solely because the query casing did not match the stored conversation text.

Validation

  • just fmt
  • cargo test -p codex-app-server thread_search_returns_content_matches
  • cargo test -p codex-rollout
  • just bazel-lock-update
  • just bazel-lock-check
  • cargo build -p codex-cli
  • launched a local Electron dev instance with the rebuilt CLI binary

@fc-oai fc-oai marked this pull request as ready for review May 21, 2026 21:11
@fc-oai fc-oai merged commit 05cf2fc into main May 21, 2026
31 checks passed
@fc-oai fc-oai deleted the fc/thread-search-case-insensitive branch May 21, 2026 21:14
@github-actions github-actions Bot locked and limited conversation to collaborators May 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants