Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 101e4b3c61
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
971a875 to
4663a5d
Compare
viyatb-oai
reviewed
May 28, 2026
Collaborator
viyatb-oai
left a comment
There was a problem hiding this comment.
Found one P2 regression in the deny-read plus zsh-fork approval flow; an inline suggested fix is attached.
Collaborator
Author
|
@codex review |
2e323c1 to
4798594
Compare
viyatb-oai
reviewed
May 28, 2026
Collaborator
viyatb-oai
left a comment
There was a problem hiding this comment.
There is one remaining sibling regression in unified-exec zsh-fork after the shell-command fix; an inline suggested fix is attached.
viyatb-oai
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Permission profiles can mark filesystem entries as unreadable with
denyrules, including glob patterns. Several shell execution paths treated known-safe commands or execpolicyallowrules as sufficient to run outside the filesystem sandbox. That is not valid for read-capable commands: for example,catorlsmay be reasonable to allow generally, but dropping the sandbox would also drop deny-read constraints such as**/*.env.What changed
allowdecisions continue inside the current sandbox when deny-read restrictions are active.Verification
cargo test -p codex-core tools::sandboxing::testscargo test -p codex-core tools::runtimes::shell::unix_escalation::testscargo test -p codex-core shell_command_enforces_glob_deny_read_policy