feat(tui): render next prompt suggestions [3 of 3]#23976
Open
fcoury-oai wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c55c12f7e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
da376d6 to
0be847c
Compare
0be847c to
c749a94
Compare
This was referenced May 22, 2026
ebf3205 to
ea98223
Compare
c749a94 to
750cc7e
Compare
ea98223 to
4c9c125
Compare
750cc7e to
4aa8ee6
Compare
4c9c125 to
ed2c40a
Compare
4aa8ee6 to
d29c381
Compare
ed2c40a to
02683d5
Compare
d29c381 to
4054461
Compare
02683d5 to
774f228
Compare
4054461 to
c52d0e5
Compare
774f228 to
14760db
Compare
c52d0e5 to
c8d8cbd
Compare
14760db to
072c55c
Compare
c8d8cbd to
e470cae
Compare
b003831 to
415c590
Compare
e470cae to
f00ebd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After the app-server can produce a next-prompt suggestion, the TUI needs to request it at the right moments and show it as lightweight composer ghost text without submitting on behalf of the user.
What changed
Tabwithout immediately submitting.Testing
RUST_MIN_STACK=8388608 CARGO_TARGET_DIR=/private/tmp/codex-next-suggestion-stack-target cargo test -p codex-tui next_prompt_suggestioncargo insta pending-snapshots --manifest-path tui/Cargo.tomlCARGO_TARGET_DIR=/private/tmp/codex-next-suggestion-stack-target ./tools/argument-comment-lint/run.py -p codex-core -p codex-app-server-protocol -p codex-app-server -p codex-tuiManual smoke retained from the original combined PR: a fresh temporary-home TUI session produced the expected ghost-text suggestion after a completed turn; resumed thread attachment invoked
thread/suggestNextPrompt; incomplete active tool flow suppressed suggestions instead of showing stale text.Stack