chore: stop consuming legacy config profiles#24076
Merged
Merged
Conversation
jif-oai
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d6451fcb79
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The old config-profile mechanism should no longer influence runtime behavior now that profile selection has moved to file-based
--profileconfig files. Core already rejects a selected legacyprofile = "..."with a migration error incore/src/config/mod.rs, but a few residual consumers still read legacy[profiles.*]data while performing managed-feature checks and personality migration.That kept dead legacy profile state relevant after selection had been removed, and could make personality migration depend on a stale or missing old profile.
What changed
[profiles.*]feature settings when validating managed feature requirements.personalityandmodel_providersettings.ConfigToml::get_config_profilehelper.This keeps the legacy
profile/profilesconfig shape available for the remaining compatibility and migration diagnostics; it only removes these behavior consumers.Verification
core/tests/suite/personality_migration.rsfor the new legacy-profile behavior.cargo test -p codex-core personality_migration.