Conversation
shijie-oai
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The package builder has an Intel macOS release target (
x86_64-apple-darwin) whose DotSlash platform ismacos-x86_64, butscripts/codex_package/codex-zshonly listed Apple Silicon macOS plus Linux platforms. Because zsh is fetched withmissing_ok=True, Intel macOS packages could miss the patched zsh resource instead of resolving a prebuilt artifact.The
rust-v0.134.0-alpha.3release now publishescodex-zsh-x86_64-apple-darwin.tar.gz, so the manifest can cover that platform. See the release assets in https://github.com/openai/codex/releases/tag/rust-v0.134.0-alpha.3 and the completed release job at https://github.com/openai/codex/actions/runs/26319528477/job/77485808896.Relevant existing mappings:
x86_64-apple-darwinmaps tomacos-x86_64: https://github.com/openai/codex/blob/main/scripts/codex_package/targets.py#L88-L93scripts/codex_package/codex-zsh: https://github.com/openai/codex/blob/main/scripts/codex_package/zsh.py#L14-L22What Changed
codex-zshDotSlash entries torust-v0.134.0-alpha.3release URLs and refreshed their size and SHA-256 metadata.macos-x86_64entry forcodex-zsh-x86_64-apple-darwin.tar.gz.Verification
codex-zsh-*.tar.gzrelease assets fromrust-v0.134.0-alpha.3, computed theirwc -csizes andshasum -a 256digests, and verified each archive containscodex-zsh/bin/zsh.python3 -m unittest discover -s scripts/codex_package -p 'test_*.py'