Skip to content

fix(tui): integrate vim line-end behavior [1 of 9]#24476

Draft
fcoury-oai wants to merge 8 commits into
mainfrom
fcoury/vim-integrate-line-end
Draft

fix(tui): integrate vim line-end behavior [1 of 9]#24476
fcoury-oai wants to merge 8 commits into
mainfrom
fcoury/vim-integrate-line-end

Conversation

@fcoury-oai
Copy link
Copy Markdown
Contributor

@fcoury-oai fcoury-oai commented May 25, 2026

Why

The text-object work in #24382 is independent of #24380, while later Vim layers need both foundations in a single dependent base.

What Changed

  • Port corrected repeated e and operator de behavior from fix(tui): complete vim word-end and line-end behavior #24380 onto the text-object branch.
  • Add C and corrected multiline line-end behavior on that same base.
  • Regenerate the combined keymap picker snapshots and preserve the existing schema addition.

Stack

  1. This PR - integrate Vim word/line-end behavior
  2. feat(tui): complete vim change operations [2 of 9] #24477 - complete Vim change operations and aliases
  3. feat(tui): add vim find and till motions [3 of 9] #24480 - add find/till motions and repeat-find
  4. feat(tui): add vim prose text objects [4 of 9] #24483 - add prose text objects
  5. feat(tui): add vim tag text objects [5 of 9] #24486 - add tag text objects
  6. feat(tui): add vim command counts [6 of 9] #24487 - add command counts
  7. feat(tui): add vim named registers [7 of 9] #24492 - add named registers
  8. feat(tui): add vim visual modes [8 of 9] #24496 - add visual modes
  9. feat(tui): add vim dot repeat [9 of 9] #24498 - add dot repeat

Testing

  • just write-config-schema
  • just fmt
  • just test -p codex-config
  • just test -p codex-tui (only the two pre-existing guardian feature-flag tests fail)
  • cargo insta pending-snapshots --manifest-path tui/Cargo.toml (no pending snapshots)
  • just fix -p codex-tui
  • just argument-comment-lint-from-source -p codex-tui -p codex-config (passes; emits existing workspace-wide unknown-lint warnings)

Known unrelated codex-tui failures:

  • app::tests::update_feature_flags_disabling_guardian_clears_manual_review_policy_without_history
  • app::tests::update_feature_flags_disabling_guardian_clears_review_policy_and_restores_default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant