fix(tui): integrate vim line-end behavior [1 of 9]#24476
Draft
fcoury-oai wants to merge 8 commits into
Draft
Conversation
This was referenced May 25, 2026
727b57e to
e72cf32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The text-object work in #24382 is independent of #24380, while later Vim layers need both foundations in a single dependent base.
What Changed
eand operatordebehavior from fix(tui): complete vim word-end and line-end behavior #24380 onto the text-object branch.Cand corrected multiline line-end behavior on that same base.Stack
Testing
just write-config-schemajust fmtjust test -p codex-configjust test -p codex-tui(only the two pre-existing guardian feature-flag tests fail)cargo insta pending-snapshots --manifest-path tui/Cargo.toml(no pending snapshots)just fix -p codex-tuijust argument-comment-lint-from-source -p codex-tui -p codex-config(passes; emits existing workspace-wide unknown-lint warnings)Known unrelated
codex-tuifailures:app::tests::update_feature_flags_disabling_guardian_clears_manual_review_policy_without_historyapp::tests::update_feature_flags_disabling_guardian_clears_review_policy_and_restores_default