Skip to content

feat(tui): render markdown tables in app style [1 of 2]#24489

Merged
fcoury-oai merged 1 commit into
mainfrom
fcoury/app-style-markdown-tables
May 27, 2026
Merged

feat(tui): render markdown tables in app style [1 of 2]#24489
fcoury-oai merged 1 commit into
mainfrom
fcoury/app-style-markdown-tables

Conversation

@fcoury-oai
Copy link
Copy Markdown
Contributor

@fcoury-oai fcoury-oai commented May 25, 2026

Stack

Why

Markdown tables currently render as boxed terminal grids, which gives ordinary assistant output a heavier visual treatment than surrounding rich text. This row-separated layout is the best match for how the App renders tables, while accented headers remain distinguishable even when a terminal font renders bold subtly.

Codex CLI - Before

CleanShot 2026-05-25 at 18 46 17

Codex CLI - After

image

Codex App

CleanShot 2026-05-25 at 18 45 04

What Changed

  • Render markdown tables as padded, aligned rows without an enclosing box.
  • Style table headers with the active syntax-theme accent plus bold text, while keeping separators low contrast and theme-aware.
  • Use a segmented heavy header rule and thin body-row rules, preserving wrapping, narrow-width fallback, streaming parity, and rich-history rendering.
  • Update focused assertions and snapshots for the final table layout.

How to Test

  1. Render a markdown table in the TUI with several rows and columns.
  2. Confirm the header uses the active theme accent, rows use one-character interior padding, and the table has no enclosing box.
  3. Confirm the header is followed by segmented rules and multiple body rows are separated by muted segmented rules.
  4. Render the same table while streaming and in history/raw-mode toggles; the final rich layout should remain stable.
  5. Render a narrow table with long content and verify wrapping or pipe fallback does not overflow.

Validation

  • just test -p codex-tui table
  • just test -p codex-tui streaming::controller::tests
  • just argument-comment-lint-from-source -p codex-tui -- --all-targets
  • just fix -p codex-tui
  • just fmt

just test -p codex-tui was also run after accepting the snapshots; it fails only in the unrelated existing guardian app tests update_feature_flags_disabling_guardian_clears_review_policy_and_restores_default and update_feature_flags_disabling_guardian_clears_manual_review_policy_without_history.

Copy link
Copy Markdown
Collaborator

@etraut-openai etraut-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I really like the new treatment

@fcoury-oai fcoury-oai merged commit 6b4b15a into main May 27, 2026
31 checks passed
@fcoury-oai fcoury-oai deleted the fcoury/app-style-markdown-tables branch May 27, 2026 19:18
@github-actions github-actions Bot locked and limited conversation to collaborators May 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants