Skip to content

tui: include exec sessions in resume list#24503

Merged
etraut-openai merged 1 commit into
mainfrom
etraut/resume-exec-threads
May 26, 2026
Merged

tui: include exec sessions in resume list#24503
etraut-openai merged 1 commit into
mainfrom
etraut/resume-exec-threads

Conversation

@etraut-openai
Copy link
Copy Markdown
Collaborator

Why

Fixes #24502.

codex resume --include-non-interactive should include sessions created by codex exec, but the TUI was sending no sourceKinds filter to thread/list for that mode. thread/list treats omitted or empty sourceKinds as interactive-only (cli, vscode), so exec sessions were still filtered out.

What Changed

  • Added a shared TUI resume_source_kinds helper so both resume lookup paths always pass explicit sourceKinds to thread/list.
  • Kept the default resume behavior scoped to cli and vscode.
  • Made --include-non-interactive include exec and appServer sessions, while continuing to exclude subagent and unknown sources.

Verification

Added focused coverage for both affected TUI request builders:

  • latest_session_lookup_params_can_include_non_interactive_sources
  • remote_thread_list_params_can_include_non_interactive_sources

Copy link
Copy Markdown
Contributor

@fcoury-oai fcoury-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! 👍

@etraut-openai etraut-openai merged commit b84c589 into main May 26, 2026
31 checks passed
@etraut-openai etraut-openai deleted the etraut/resume-exec-threads branch May 26, 2026 15:27
@github-actions github-actions Bot locked and limited conversation to collaborators May 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

codex resume --include-non-interactive does not show exec sessions

2 participants