tui: include exec sessions in resume list#24503
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixes #24502.
codex resume --include-non-interactiveshould include sessions created bycodex exec, but the TUI was sending nosourceKindsfilter tothread/listfor that mode.thread/listtreats omitted or emptysourceKindsas interactive-only (cli,vscode), so exec sessions were still filtered out.What Changed
resume_source_kindshelper so both resume lookup paths always pass explicitsourceKindstothread/list.cliandvscode.--include-non-interactiveincludeexecandappServersessions, while continuing to exclude subagent and unknown sources.Verification
Added focused coverage for both affected TUI request builders:
latest_session_lookup_params_can_include_non_interactive_sourcesremote_thread_list_params_can_include_non_interactive_sources