Use thread config for TUI MCP inventory#24532
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 79f0e32ed7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f87a5c5fb5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fcoury-oai
left a comment
fcoury-oai
left a comment
There was a problem hiding this comment.
Smoke tested both /mcp and /mcp verbose. Code looks good! 👍
2 participants
Summary
/mcpin the TUI should reflect the current loaded thread, including project-local MCP servers from that thread config. Before this change,mcpServerStatus/listonly read the latest global MCP config, so the active chat could miss project-local servers.This adds optional
threadIdtomcpServerStatus/list. When present, app-server resolves the loaded thread and lists MCP status from the refreshed effective config for that thread; when omitted, existing global config behavior stays unchanged.The TUI now sends the active chat thread id for
/mcpand/mcp verbose, carries that origin through the async inventory result, and ignores stale completions if the user has switched threads before the fetch returns. The app-server schemas were regenerated.Follow-up
Once this app-server API change lands, the desktop app should make the same
threadIdplumbing so its MCP inventory also uses the current thread config.Fixes #23874